tailscale: build with less features #24706
Conversation
|
There is missing commit description itself to know in CLI and as well within git commands to know why those features were disabled. |
See https://github.com/tailscale/tailscale/blob/main/build_dist.sh#L40. This shaves off about 500kb from the final executable. Signed-off-by: Zephyr Lykos <[email protected]>
Signed-off-by: Zephyr Lykos <[email protected]>
| @@ -28,7 +28,7 @@ GO_PKG:=\ | |||
| tailscale.com/cmd/tailscaled | |||
| GO_PKG_LDFLAGS:=-X 'tailscale.com/version.longStamp=$(PKG_VERSION)-$(PKG_RELEASE) (OpenWrt)' | |||
| GO_PKG_LDFLAGS_X:=tailscale.com/version.shortStamp=$(PKG_VERSION) | |||
| GO_PKG_TAGS:=ts_include_cli | |||
| GO_PKG_TAGS:=ts_include_cli,ts_omit_aws,ts_omit_bird,ts_omit_tap,ts_omit_kube,ts_omit_completion | |||
There was a problem hiding this comment.
However, you added commit description exactly the same as it is in the pull request, but still you have decided to build it with less features, you pointed us to https://github.com/tailscale/tailscale/blob/main/build_dist.sh#L40 and still I am not sure what was the reason to have fewer features.
While looking at https://openwrt.org/submitting-patches, I see:
It should explain to a competent reader why you made this commit.
|
etc. These omit flags are those proposed by the project authors themselves to reduce binary footprint (at cost of lesser used functionality). |
|
continued in #24987 |
|
There was no need to create a new PR, you could use the existing one.
Dne st 18. 9. 2024 8:44 uživatel Zephyr Lykos ***@***.***>
napsal:
… continued in #24987 <#24987>
—
Reply to this email directly, view it on GitHub
<#24706 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7IDVBNMI2D2OGVL3XREOTZXEON7AVCNFSM6AAAAABLZQUJ42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJXGYZTIOJVGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
This one was on the master branch from my repo, so I have to open a new one. |
|
Never ever create pull request from the master branch, thats why you should use feature branches. You could also use master branch and create the other pull requests from different branch. |
Maintainer: me
Compile tested: aarch64_cortex-a53 @ SNAPSHOT
Run tested: not yet
Description:
See https://github.com/tailscale/tailscale/blob/main/build_dist.sh#L40.
This shaves off about 500kb from the final executable.